RESOLVED FIXED Bug 37875
Web Inspector: add basic script editing capabilities to the front-end. 
https://bugs.webkit.org/show_bug.cgi?id=37875
Summary Web Inspector: add basic script editing capabilities to the front-end.
Pavel Feldman
Reported 2010-04-20 11:30:18 PDT
This also contains a PoC implementation for the Chromium.
Attachments
[PATCH] Proposed change. (20.03 KB, patch)
2010-04-20 11:36 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2010-04-20 11:35:17 PDT
Why only PoC for Chromium?
Pavel Feldman
Comment 2 2010-04-20 11:36:32 PDT
Created attachment 53856 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 3 2010-04-20 11:46:58 PDT
Comment on attachment 53856 [details] [PATCH] Proposed change. > + canEditScripts: function() > + { > + return !!InspectorBackend.editScriptLine; > + }, > + > + editScriptLine: function(sourceID, line, newContent, callback) > + { > + if (!this.canEditScripts()) > + return; > + var callbackId = WebInspector.Callback.wrap(callback) > + InspectorBackend.editScriptLine(callbackId, sourceID, line, newContent); > + }, > + Consider inlining these methods.
Pavel Feldman
Comment 4 2010-04-20 13:19:18 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/ScriptDebugServer.cpp M WebCore/inspector/front-end/ScriptView.js M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/TextEditorHighlighter.js M WebCore/inspector/front-end/TextEditorModel.js M WebCore/inspector/front-end/TextViewer.js M WebCore/inspector/front-end/inspector.js M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DebuggerAgent.js M WebKit/chromium/src/js/DevTools.js M WebKit/chromium/src/js/InspectorControllerImpl.js Committed r57909
Note You need to log in before you can comment on or make changes to this bug.