Bug 37869 – Move URopeImpl to its own .h/.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Currently Ropes are implemented by the class URopeImpl, which is defined in UStringImpl.h, and then typedefed to the name JSString::Rope.

Remove the typedef, and rename all uses of URopeImpl and JSString::Rope to just RopeImpl.

Move RopeImpl to its own header, and remove all remaining references to ropes from UStringImpl (rename UStringOrRopeImpl to UStringImplBase, rename or move the isRope & deref methods from UStringOrRopeImpl).

[Gavin Barraclough]

Created attachment 53843 [details]
The patch

[WebKit Review Bot]

Attachment 53843 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/RopeImpl.h:59:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/runtime/RopeImpl.h:59:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Attachment 53843 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1829004

[Geoffrey Garen]

Comment on attachment 53843 [details]
The patch

+    bool isInvalid() { return (m_refCountAndFlags & s_refCountInvalid) == s_refCountInvalid; }

Let's reverse the meaning of this function, and call it "isStringImpl". And also give an appropriate name to s_refCountInvalid.

r=me

[Gavin Barraclough]

landed in r57904