EventSource needs to be marked as an ActiveDomType.
Created attachment 53813 [details] Patch
Hi Nate, Ages ago I implemented the binding for eventsource, and turns out I didn't fully enable it, so looks like it got a bit stale. As a follow up of this change, I'll enable eventsource by default on the other side and will make sure the layout tests are properly turned on this time.. :) Would you please take a look at this patch? Thanks! Marcus
Created attachment 53823 [details] Patch (fixes error message required by fast/eventsource layout tests).
Comment on attachment 53823 [details] Patch (fixes error message required by fast/eventsource layout tests). Ok, looks good. Do you need cq+ on this?
thanks for the quick review! yep, I need cq+ thanks, marcus (In reply to comment #4) > (From update of attachment 53823 [details]) > Ok, looks good. > > Do you need cq+ on this?
Comment on attachment 53823 [details] Patch (fixes error message required by fast/eventsource layout tests). cq+ then. So will Chromium be enabling eventsource on tip of tree and running these tests soon then?
(In reply to comment #6) > (From update of attachment 53823 [details]) > cq+ then. > > So will Chromium be enabling eventsource on tip of tree and running these tests > soon then? precisely! once we roll this change, I'll enable eventsource: http://codereview.chromium.org/557037 and then once it's enable, I'll turn on the tests: https://bugs.webkit.org/show_bug.cgi?id=37863 just needs a few rounds to get it through both sides.
Comment on attachment 53823 [details] Patch (fixes error message required by fast/eventsource layout tests). Clearing flags on attachment: 53823 Committed r57967: <http://trac.webkit.org/changeset/57967>
All reviewed patches have been landed. Closing bug.