Bug 37853 - Update EFL port to match recent API changes.
Summary: Update EFL port to match recent API changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-20 06:08 PDT by Gustavo Sverzut Barbieri
Modified: 2010-04-21 05:32 PDT (History)
2 users (show)

See Also:


Attachments
Update EFL port to match recent API changes (7.14 KB, patch)
2010-04-20 06:13 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
Update EFL port to match recent API changes (7.17 KB, patch)
2010-04-20 06:37 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
Update EFL port to match recent API changes (without Plugins) (8.15 KB, patch)
2010-04-20 10:10 PDT, Gustavo Sverzut Barbieri
aroben: review-
Details | Formatted Diff | Diff
Update EFL port to match recent API changes (without Plugins) (8.12 KB, patch)
2010-04-20 10:15 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Sverzut Barbieri 2010-04-20 06:08:08 PDT
Recent changes to WebKit were not applied to WebKit-EFL and broke its compile. Of course nobody noticed it since we still have patches missing to fully integrate it, and we have no build-bot set :-(

Changes required are:

 * WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.{cpp,h}: add didTransferChildFrameToNewDocument() and dispatchDidChangeIcons().

 * WebCore/platform/graphics/efl/ImageEfl.cpp: add now missing include.

 * WebCore/platform/efl/LocalizedStringsEfl.cpp: add missing strings for plugin handling (crash, missing).

 * WebCore/platform/efl/MIMETypeRegistryEfl.cpp: add isApplicationPluginMIMEType().

 * WebCore/platform/efl/FileSystemEfl.cpp: remove closeFile() and writeToFile() as they are now in WebCore/platform/posix/FileSystemPOSIX.cpp.

 * WebKit/efl/WebCoreSupport/EditorClientEfl.cpp: use new common WindowsKeyboardCodes.h instead of KeyboardCodes.h.
Comment 1 Gustavo Sverzut Barbieri 2010-04-20 06:13:42 PDT
Created attachment 53806 [details]
Update EFL port to match recent API changes

This is a quite simple patch that unbreaks the EFL port given the recent WebCore changes, basically introduces couple of notImplemented and remove functions that were made common elsewhere.
Comment 2 WebKit Review Bot 2010-04-20 06:15:24 PDT
Attachment 53806 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKit/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
WebKit/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gustavo Sverzut Barbieri 2010-04-20 06:36:58 PDT
Comment on attachment 53806 [details]
Update EFL port to match recent API changes

clear flags as patch had tabs in ChangeLog
Comment 4 Gustavo Sverzut Barbieri 2010-04-20 06:37:37 PDT
Created attachment 53808 [details]
Update EFL port to match recent API changes

New version without tabs in ChangeLogs, sorry.
Comment 5 Nikolas Zimmermann 2010-04-20 06:44:23 PDT
Comment on attachment 53808 [details]
Update EFL port to match recent API changes

Looks good to me. r=me.
Comment 6 Gustavo Sverzut Barbieri 2010-04-20 10:10:01 PDT
Created attachment 53835 [details]
Update EFL port to match recent API changes (without Plugins)

New patch that disables Plugin-related code so we can build with Plugin*None and without using PluginView.cpp/PluginDatabase.cpp and others, as mentioned by aroben at https://bugs.webkit.org/show_bug.cgi?id=37478#c23
Comment 7 Adam Roben (:aroben) 2010-04-20 10:11:57 PDT
Comment on attachment 53835 [details]
Update EFL port to match recent API changes (without Plugins)

> Index: WebCore/ChangeLog
> +++ WebCore/platform/graphics/efl/ImageEfl.cpp	(working copy)
> @@ -28,8 +28,8 @@
>  
>  #include "config.h"
>  #include "Image.h"
> -
>  #include "BitmapImage.h"
> +#include "SharedBuffer.h"

You should leave in the blank line after Image.h.

Everything else looks fine, though.
Comment 8 Gustavo Sverzut Barbieri 2010-04-20 10:15:06 PDT
Created attachment 53836 [details]
Update EFL port to match recent API changes (without Plugins)

Fixed the new line reported by aroben.
Comment 9 Adam Roben (:aroben) 2010-04-20 10:16:03 PDT
Comment on attachment 53836 [details]
Update EFL port to match recent API changes (without Plugins)

r=me
Comment 10 Gustavo Sverzut Barbieri 2010-04-20 10:17:20 PDT
Comment on attachment 53808 [details]
Update EFL port to match recent API changes

Clear flags as it is obsolete.
Comment 11 WebKit Commit Bot 2010-04-21 05:32:45 PDT
Comment on attachment 53836 [details]
Update EFL port to match recent API changes (without Plugins)

Clearing flags on attachment: 53836

Committed r57970: <http://trac.webkit.org/changeset/57970>
Comment 12 WebKit Commit Bot 2010-04-21 05:32:50 PDT
All reviewed patches have been landed.  Closing bug.