Recent changes to WebKit were not applied to WebKit-EFL and broke its compile. Of course nobody noticed it since we still have patches missing to fully integrate it, and we have no build-bot set :-( Changes required are: * WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.{cpp,h}: add didTransferChildFrameToNewDocument() and dispatchDidChangeIcons(). * WebCore/platform/graphics/efl/ImageEfl.cpp: add now missing include. * WebCore/platform/efl/LocalizedStringsEfl.cpp: add missing strings for plugin handling (crash, missing). * WebCore/platform/efl/MIMETypeRegistryEfl.cpp: add isApplicationPluginMIMEType(). * WebCore/platform/efl/FileSystemEfl.cpp: remove closeFile() and writeToFile() as they are now in WebCore/platform/posix/FileSystemPOSIX.cpp. * WebKit/efl/WebCoreSupport/EditorClientEfl.cpp: use new common WindowsKeyboardCodes.h instead of KeyboardCodes.h.
Created attachment 53806 [details] Update EFL port to match recent API changes This is a quite simple patch that unbreaks the EFL port given the recent WebCore changes, basically introduces couple of notImplemented and remove functions that were made common elsewhere.
Attachment 53806 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKit/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebKit/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 53806 [details] Update EFL port to match recent API changes clear flags as patch had tabs in ChangeLog
Created attachment 53808 [details] Update EFL port to match recent API changes New version without tabs in ChangeLogs, sorry.
Comment on attachment 53808 [details] Update EFL port to match recent API changes Looks good to me. r=me.
Created attachment 53835 [details] Update EFL port to match recent API changes (without Plugins) New patch that disables Plugin-related code so we can build with Plugin*None and without using PluginView.cpp/PluginDatabase.cpp and others, as mentioned by aroben at https://bugs.webkit.org/show_bug.cgi?id=37478#c23
Comment on attachment 53835 [details] Update EFL port to match recent API changes (without Plugins) > Index: WebCore/ChangeLog > +++ WebCore/platform/graphics/efl/ImageEfl.cpp (working copy) > @@ -28,8 +28,8 @@ > > #include "config.h" > #include "Image.h" > - > #include "BitmapImage.h" > +#include "SharedBuffer.h" You should leave in the blank line after Image.h. Everything else looks fine, though.
Created attachment 53836 [details] Update EFL port to match recent API changes (without Plugins) Fixed the new line reported by aroben.
Comment on attachment 53836 [details] Update EFL port to match recent API changes (without Plugins) r=me
Comment on attachment 53808 [details] Update EFL port to match recent API changes Clear flags as it is obsolete.
Comment on attachment 53836 [details] Update EFL port to match recent API changes (without Plugins) Clearing flags on attachment: 53836 Committed r57970: <http://trac.webkit.org/changeset/57970>
All reviewed patches have been landed. Closing bug.