[chromium] new-run-webkit-tests --use-drt should run on Linux
Created attachment 53783 [details] Patch
Created attachment 53788 [details] Patch
(In reply to comment #2) > Created an attachment (id=53788) [details] > Patch Updated to fix the output directory of the tests. It was writing the test results into xcodebuild.
Comment on attachment 53788 [details] Patch WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:91 + def results_directory(self): Why is this code copy/pasted twice? It seems better to have it in the base class if its used by more than one subclass. WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:167 + def _path_to_image_diff(self): This code looks copy/pasted too. WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py:101 + def results_directory(self): Here the code is again. We don't want any copy/paste code.
Created attachment 54115 [details] Patch
(In reply to comment #4) > (From update of attachment 53788 [details]) > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:91 > + def results_directory(self): > Why is this code copy/pasted twice? It seems better to have it in the base > class if its used by more than one subclass. I copied the functions because they call _build_path() which is only defined in the implementation classes. But I see other methods doing this, so I guess that's ok.
Comment on attachment 54115 [details] Patch Looks sane, but where are the tests?
Created attachment 55519 [details] Patch
(In reply to comment #7) > (From update of attachment 54115 [details]) > Looks sane, but where are the tests? Good point, added some tests.
Maybe Kent-san can review this now. Eric just wanted some tests added earlier.
Comment on attachment 55519 [details] Patch This looks OK. I'll set r+ tomorrow if no one adds review comments.
Committed r59743: <http://trac.webkit.org/changeset/59743>