Bug 37843 - [DRT/Chromium] Fix some unexpected results of editing
: [DRT/Chromium] Fix some unexpected results of editing
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Other All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 35902
  Show dependency treegraph
 
Reported: 2010-04-19 23:53 PDT by Kent Tamura
Modified: 2010-04-20 00:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2010-04-19 23:55 PDT, Kent Tamura
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-04-19 23:53:39 PDT
[DRT/Chromium] Fix some unexpected results of editing
Comment 1 Kent Tamura 2010-04-19 23:55:53 PDT
Created attachment 53777 [details]
Patch
Comment 2 Shinichiro Hamaji 2010-04-20 00:06:09 PDT
Comment on attachment 53777 [details]
Patch

Looks good!

Side note: the corresponding file seems to be src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We have only one startContainer call in the chromium's code so this would be just a typo.

By the way, I think it's nice to have this kind of info in ChangeLog. Could you update the ChangeLog before you land?
Comment 3 Kent Tamura 2010-04-20 00:08:52 PDT
(In reply to comment #2)
> (From update of attachment 53777 [details])
> Looks good!
> 
> Side note: the corresponding file seems to be
> src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We
> have only one startContainer call in the chromium's code so this would be just
> a typo.
> 
> By the way, I think it's nice to have this kind of info in ChangeLog. Could you
> update the ChangeLog before you land?

Right.  This was my failure during porting test_webview_delegate.cc.
I'll update the ChangeLog.
Comment 4 Kent Tamura 2010-04-20 00:15:20 PDT
Committed r57876: <http://trac.webkit.org/changeset/57876>