Bug 37841 - Error when running test-webkitpy (webkitpy.layout_tests.run_webkit_tests_unittest.DryrunTest)
Summary: Error when running test-webkitpy (webkitpy.layout_tests.run_webkit_tests_unit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 21:42 PDT by Daniel Bates
Modified: 2010-04-20 09:54 PDT (History)
5 users (show)

See Also:


Attachments
Error message and backtrace (2.01 KB, text/plain)
2010-04-19 21:44 PDT, Daniel Bates
no flags Details
Patch (7.28 KB, patch)
2010-04-19 22:58 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-04-19 21:42:04 PDT
As of r57867, I get the following error and backtrace when I run WebKitTools/Scripts/test-webkitpy:

ERROR: test_basics (webkitpy.layout_tests.run_webkit_tests_unittest.DryrunTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 63, in test_basics
    'fast/html']))
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 41, in passing_run
    res = run_webkit_tests.main(options, args, False)
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 1428, in main
    port_obj = port.get(options.platform, options)
  File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py", line 63, in get
    import dryrun
ImportError: No module named dryrun
Comment 1 Daniel Bates 2010-04-19 21:44:55 PDT
Created attachment 53769 [details]
Error message and backtrace

For completeness, the output of running WebKitTools/Scripts/test-webkitpy as of r57867.
Comment 2 Dirk Pranke 2010-04-19 22:58:39 PDT
Created attachment 53772 [details]
Patch
Comment 3 Dirk Pranke 2010-04-19 23:00:07 PDT
grr. some combination of git, webkit-patch, and my own stupidity screwed me. Fixed shortly.
Comment 4 Dirk Pranke 2010-04-19 23:00:47 PDT
fixed in r57871.
Comment 5 Shinichiro Hamaji 2010-04-19 23:03:51 PDT
(In reply to comment #4)
> fixed in r57871.

Thanks for the fix. I saw another error when I ran the test without chromium's tree.

======================================================================
FAIL: test_basics (webkitpy.layout_tests.run_webkit_tests_unittest.DryrunTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 67, in test_basics
    'fast/html']))
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 41, in passing_run
    res = run_webkit_tests.main(options, args, False)
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 1560, in main
    port_obj.setup_test_run()
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py", line 163, in setup_test_run
    dump_render_tree_binary_path = self._path_to_driver()
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 151, in _path_to_driver
    'Contents', 'MacOS', self.driver_name())
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 99, in _build_path
    return self.path_from_chromium_base('xcodebuild', *comps)
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py", line 144, in path_from_chromium_base
    abspath)
AssertionError: could not find Chromium base dir from /Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.pyc

----------------------------------------------------------------------
Ran 379 tests in 2.484s

FAILED (failures=1)
Comment 6 Dirk Pranke 2010-04-19 23:14:53 PDT
makes sense. I hadn't tested that possibility. I'll comment those tests out for now.
Comment 7 Dirk Pranke 2010-04-19 23:18:38 PDT
Committed r57872: <http://trac.webkit.org/changeset/57872>
Comment 8 Chris Jerdonek 2010-04-19 23:53:38 PDT
By the way, have any of you noticed that the output of test-webkitpy "flickers" during one of the unit tests -- starting perhaps less than a week ago?

It doesn't seem like that should need to happen.  It may be a sign that a better test mechanism can be used.  I think I found that the issue occurs at least during the following test:

test-webkitpy webkitpy.layout_tests.run_webkit_tests_unittest.MainTest
Comment 9 Dirk Pranke 2010-04-20 09:54:41 PDT
(In reply to comment #8)
> By the way, have any of you noticed that the output of test-webkitpy "flickers"
> during one of the unit tests -- starting perhaps less than a week ago?
> 
> It doesn't seem like that should need to happen.  It may be a sign that a
> better test mechanism can be used.  I think I found that the issue occurs at
> least during the following test:
> 
> test-webkitpy webkitpy.layout_tests.run_webkit_tests_unittest.MainTest

At least some of the flickering occurs during running run_webkit_tests_unittest.py and is the result of not disabling the progress bar properly, I think. I'll look into that today while getting the remaining logging cleaned up.