Bug 37838 - new-run-webkit-tests: add a --no-retry-failures flag
Summary: new-run-webkit-tests: add a --no-retry-failures flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 18:40 PDT by Dirk Pranke
Modified: 2010-04-23 13:03 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.13 KB, patch)
2010-04-19 18:41 PDT, Dirk Pranke
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-19 18:40:26 PDT
We should add a --no-retry-failures flag in case we want to check something but don't want to retry things.
Comment 1 Dirk Pranke 2010-04-19 18:41:58 PDT
Created attachment 53760 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-19 18:46:44 PDT
Comment on attachment 53760 [details]
Patch

Why do we want more options?  I'm trying to cut down on the number of options the user sees so we can make --help less intimidating.  These seem unlikely for a user to use.
Comment 3 Dirk Pranke 2010-04-19 18:49:28 PDT
(In reply to comment #2)
> (From update of attachment 53760 [details])
> Why do we want more options?  I'm trying to cut down on the number of options
> the user sees so we can make --help less intimidating.  These seem unlikely for
> a user to use.

Certainly --retry-failures is unlikely to be used, since it's the default.

I would be fine if --no-retry-failures was hidden, but I'd like for it to be there, especially to help w/ unit testing coverage.
Comment 4 Adam Barth 2010-04-22 12:54:36 PDT
Comment on attachment 53760 [details]
Patch

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1768
 +          optparse.make_option("--no-retry-failures", action="store_false",
I thought we had magic to generate the [no-] versions.
Comment 5 Eric Seidel (no email) 2010-04-22 13:00:29 PDT
I've not written the --no- magic yet.
Comment 6 Dirk Pranke 2010-04-23 12:43:25 PDT
Committed r58183: <http://trac.webkit.org/changeset/58183>
Comment 7 WebKit Review Bot 2010-04-23 13:03:04 PDT
http://trac.webkit.org/changeset/58183 might have broken Qt Linux Release