In Chromium, open a select popup. Move the browser window while the popup is showing. Expected: The popup is closed. Actual: The popup still shows.
Created attachment 53758 [details] Make a unique method to close all popups.
Comment on attachment 53758 [details] Make a unique method to close all popups. > Index: WebKit/chromium/public/WebView.h > - // DEPRECATED: WebView::hideSuggestionsPopup is the new way to access this. > - virtual void hideAutofillPopup() = 0; > - > - // Hides the suggestions popup if any are showing. > - virtual void hideSuggestionsPopup() = 0; > + // Hides any popup (suggestions, selects...) that might be showing. > + virtual void hidePopups() = 0; Won't this break Chromium when it is committed? Can you preserve the old method(s) until Chromium is switched over to only calling hidePopups? Then circle back with a cleanup patch to remove the DEPRECATED methods. Otherwise, LGTM
Created attachment 54113 [details] Preserve the old API so it does not break the Chromium build
Comment on attachment 54113 [details] Preserve the old API so it does not break the Chromium build Clearing flags on attachment: 54113 Committed r58369: <http://trac.webkit.org/changeset/58369>
All reviewed patches have been landed. Closing bug.