Bug 37832 - Cross-platform FullscreenVideoController
Summary: Cross-platform FullscreenVideoController
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 16:18 PDT by Philippe Normand
Modified: 2019-10-14 08:58 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-04-19 16:18:12 PDT
The WebKit/win/FullscreenVideoController could be moved in a common WebKit directory. The windows-specific bits should be implemented in a sub-class. This way other ports could reuse the code.
Comment 1 Chris Marrin 2010-04-19 16:20:15 PDT
There is an issue with where to put this. There are no cross-platform directories in WebKit. Should it be:

1) In WebKit/common (or something)

2) In WebCore with subclasses in WebKit (ick!)

3) All in WebCore

I'm not sure what the best approach is
Comment 2 Philippe Normand 2010-07-11 23:43:46 PDT
Not sure anymore this is worth the effort. In the end the common code would only be a few methods, mainly proxies to the HTMLMediaElement API (play, pause, etc)