Bug 37829 - Wrong header being included in FontPlatformDataCairo.cpp
Summary: Wrong header being included in FontPlatformDataCairo.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 16:01 PDT by Luís Felipe Strano Moraes
Modified: 2010-04-21 08:18 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (455 bytes, patch)
2010-04-19 16:01 PDT, Luís Felipe Strano Moraes 		no flags Details | Formatted Diff | Diff
Include just gdk instead of gtk for FontPlatformDataCairo.cpp (1.05 KB, patch)
2010-04-20 07:11 PDT, Gustavo Sverzut Barbieri 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luís Felipe Strano Moraes 2010-04-19 16:01:05 PDT 
Created attachment 53733 [details]
Proposed patch

The file WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp includes the gtk header when in fact it only uses gdk. A simple s/gtk/gdk/ fixes it (attached).
Comment 1 Gustavo Sverzut Barbieri 2010-04-20 07:11:42 PDT 
Created attachment 53812 [details]
Include just gdk instead of gtk for FontPlatformDataCairo.cpp

WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp just use GDK to discover if there are X settings on some screen to adjust its parameters. So no need to include gtk.h there.
Comment 2 Xan Lopez 2010-04-20 07:16:42 PDT 
Comment on attachment 53812 [details]
Include just gdk instead of gtk for FontPlatformDataCairo.cpp

r=me
Comment 3 WebKit Commit Bot 2010-04-21 08:18:52 PDT 
Comment on attachment 53812 [details]
Include just gdk instead of gtk for FontPlatformDataCairo.cpp

Clearing flags on attachment: 53812

Committed r57984: <http://trac.webkit.org/changeset/57984>
Comment 4 WebKit Commit Bot 2010-04-21 08:18:57 PDT 
All reviewed patches have been landed.  Closing bug.