NEW 37823
webkit-patch upload fails to open web browser to review diff on Windows 
https://bugs.webkit.org/show_bug.cgi?id=37823
Summary webkit-patch upload fails to open web browser to review diff on Windows
Adam Roben (:aroben)
Reported 2010-04-19 14:37:59 PDT
webkit-patch upload fails to open web browser to review diff on Windows. I think this is due to a Python bug [1]. I think we can work around it by running "cygstart foo.html". 1. http://bugs.python.org/issue1244861
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-19 14:52:29 PDT
Thanks. This should be a easy change to user.py for someone with a windows box.
Eric Seidel (no email)
Comment 2 2010-04-19 14:52:56 PDT
I wonder what Chromium has been doing to work around this. Or I guess they use windows python instead of cygwin python.
Dirk Pranke
Comment 3 2010-04-19 15:00:25 PDT
I would guess not many people use webkit-patch upload on windows.
Tony Chang
Comment 4 2010-04-19 16:58:39 PDT
I tried with windows python and webkit-patch doesn't seem to work at all. Maybe Roland has used webkit-patch and knows of a work around? Also, I suspect that no one on the Chromium team has a WebKit only checkout on their windows machine. I just set one up and "update-webkit --chromium" doesn't work (fix coming soon).
Eric Seidel (no email)
Comment 5 2010-04-19 18:31:01 PDT
Windows Python is not a supported config for WebKit. I mean, we could theoretically make it work, but right now WebKit assumes cygwin to build, run, etc.
Dirk Pranke
Comment 6 2010-04-19 18:38:49 PDT
ooh, that's confusing since cygwin python isn't supported on the Chromium-win port :(. It pretty much means you'd need to have them both in your path if you're going to do development on windows directly.
Eric Seidel (no email)
Comment 7 2010-04-19 18:41:59 PDT
It's not so much that lack of cygwin python should be unsupported. But "lack of cygwin" itself is unsupported in WebKit. We could make our python work with both. It probably wouldn't be that hard.
Dirk Pranke
Comment 8 2010-04-19 18:48:07 PDT
(In reply to comment #7) > It's not so much that lack of cygwin python should be unsupported. But "lack > of cygwin" itself is unsupported in WebKit. We could make our python work with > both. It probably wouldn't be that hard. It will probably be harder than you expect because there's a lot of operating-system specific path handling you have to worry about, and you may not be able to assume a bunch of stuff is installed that you're used to.
Note You need to log in before you can comment on or make changes to this bug.