Bug 37822 - new-run-webkit-tests: disable --use-drt on windows
Summary: new-run-webkit-tests: disable --use-drt on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 14:07 PDT by Dirk Pranke
Modified: 2010-04-19 15:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2010-04-19 14:12 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-19 14:07:02 PDT 
AFAIK, --use-drt shouldn't be supported on Windows yet, so we should test this case and error out if necessary.
Comment 1 Dirk Pranke 2010-04-19 14:12:45 PDT 
Created attachment 53720 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-19 14:57:50 PDT 
Comment on attachment 53720 [details]
Patch

Why not early-return False?
Comment 3 Dirk Pranke 2010-04-19 15:05:11 PDT 
(In reply to comment #2)
> (From update of attachment 53720 [details])
> Why not early-return False?

Because this way you actually check what else is also wrong and get all the errors at once.
Comment 4 Eric Seidel (no email) 2010-04-19 15:06:43 PDT 
Comment on attachment 53720 [details]
Patch

The "continue-after-error" behavior seems like unnecessary complexity.  But the code looks right. :)
Comment 5 Dirk Pranke 2010-04-19 15:09:42 PDT 
Comment on attachment 53720 [details]
Patch

Clearing flags on attachment: 53720

Committed r57847: <http://trac.webkit.org/changeset/57847>
Comment 6 Dirk Pranke 2010-04-19 15:09:47 PDT 
All reviewed patches have been landed.  Closing bug.