Bug 37811 - [Chromium] Windowless plugins can't set the cursor any more
Summary: [Chromium] Windowless plugins can't set the cursor any more
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stuart Morgan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 11:20 PDT by Stuart Morgan
Modified: 2010-04-20 06:23 PDT (History)
1 user (show)

See Also:


Attachments
Remove obsolete workaround (2.47 KB, patch)
2010-04-19 11:27 PDT, Stuart Morgan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Morgan 2010-04-19 11:20:45 PDT
ChromeClientImpl.cpp has a variable, m_ignoreNextSetCursor, which was used to prevent a WebKit-triggered call to setCursor from overriding what the plugin does. In bug 35132 that call was removed, so now the workaround is not necessary, and is actually preventing windowless plugins from setting cursors (since all the calls are now coming from the plugin, so it's constantly being set to true).
Comment 1 Stuart Morgan 2010-04-19 11:27:32 PDT
Created attachment 53692 [details]
Remove obsolete workaround
Comment 2 WebKit Commit Bot 2010-04-20 06:23:19 PDT
Comment on attachment 53692 [details]
Remove obsolete workaround

Clearing flags on attachment: 53692

Committed r57887: <http://trac.webkit.org/changeset/57887>
Comment 3 WebKit Commit Bot 2010-04-20 06:23:23 PDT
All reviewed patches have been landed.  Closing bug.