[Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
Created attachment 53659 [details] Patch
Comment on attachment 53659 [details] Patch User.open_url is probably better than calling webbrowser directly: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L81 it allows us to more easily mock out this code for testing. This is a rather strange class inversion. I guess eventually Chromium will be a subclass of WebKitPort.
Seems maybe we should have called them TestShellDriver and DumpRenderTreeDriver.
Comment on attachment 53659 [details] Patch I guess ChromiumPort may not have access to a tool object, which would expose the User() object, so this is probably the best we have for now.
Comment on attachment 53659 [details] Patch Clearing flags on attachment: 53659 Committed r57806: <http://trac.webkit.org/changeset/57806>
All reviewed patches have been landed. Closing bug.
(In reply to comment #2) > (From update of attachment 53659 [details]) > User.open_url is probably better than calling webbrowser directly: > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L81 > it allows us to more easily mock out this code for testing. > > This is a rather strange class inversion. I guess eventually Chromium will be > a subclass of WebKitPort. If this were to become the case, then WebKitPort should probably be merged into port/base.py. It is useful to think of base.py as declaring an interface, but it really is a base class. The only other implementations that wouldn't inherit from WebKitPort would be the testing/mock classes, and they can override whatever they need do.
I agree that I think eventually we'll push more code down into base instead of WebKitPort or ChromiumPort.