Bug 37780 - new-run-webkit-tests: some messages need to be preserved in --verbose mode
Summary: new-run-webkit-tests: some messages need to be preserved in --verbose mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 37643
  Show dependency tree / graph
 
Reported: 2010-04-18 16:04 PDT by Dirk Pranke
Modified: 2010-04-19 14:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.39 KB, patch)
2010-04-18 16:09 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-18 16:04:22 PDT 
A bunch of messages are currently disabled in --verbose mode; this means we lose profiling information. We should log all messages except for the ones that are truly incremental progress-style updates.
Comment 1 Dirk Pranke 2010-04-18 16:09:38 PDT 
Created attachment 53641 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-19 00:10:57 PDT 
Comment on attachment 53641 [details]
Patch

OK.
Comment 3 Ojan Vafai 2010-04-19 08:26:13 PDT 
This patch is fine. I think we should try to move in the direction of --verbose just implying --log all or something like that.
Comment 4 Dirk Pranke 2010-04-19 10:42:29 PDT 
(In reply to comment #3)
> This patch is fine. I think we should try to move in the direction of --verbose
> just implying --log all or something like that.

It more or less does, except it turns off the progress bars.
Comment 5 Dirk Pranke 2010-04-19 14:41:14 PDT 
Comment on attachment 53641 [details]
Patch

Clearing flags on attachment: 53641

Committed r57841: <http://trac.webkit.org/changeset/57841>
Comment 6 Dirk Pranke 2010-04-19 14:41:19 PDT 
All reviewed patches have been landed.  Closing bug.