Bug 37735 - Remove JSC specific code from WebCore::AtomicString
Summary: Remove JSC specific code from WebCore::AtomicString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-16 16:52 PDT by Gavin Barraclough
Modified: 2010-04-16 20:26 PDT (History)
3 users (show)

See Also:


Attachments
The patch (43.32 KB, patch)
2010-04-16 16:54 PDT, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-04-16 16:52:47 PDT
Add generic constructor/add/find methods that take a UChar* & length, along with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.
Comment 1 Gavin Barraclough 2010-04-16 16:54:33 PDT
Created attachment 53582 [details]
The patch
Comment 2 WebKit Review Bot 2010-04-16 17:00:12 PDT
Attachment 53582 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/text/AtomicString.cpp:194:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/text/AtomicString.cpp:243:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-04-16 17:01:23 PDT
Comment on attachment 53582 [details]
The patch

r=me!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Comment 4 WebKit Review Bot 2010-04-16 17:20:41 PDT
http://trac.webkit.org/changeset/57766 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Comment 5 Eric Seidel (no email) 2010-04-16 17:23:50 PDT
It appears this broke a bunch of bots.  Wasn't up for review long enough for the EWSes to catch it.
Comment 6 Gavin Barraclough 2010-04-16 20:26:36 PDT
Landed in r57766.