NEW 37734
Small HashSet::remove optimization 
https://bugs.webkit.org/show_bug.cgi?id=37734
Summary Small HashSet::remove optimization
Jędrzej Nowacki
Reported 2010-04-16 16:36:26 PDT
Created attachment 53579 [details] idea I think that we can skip check inside the function, at least for disabled CHECK_HASHTABLE_CONSISTENCY. The same check is done inside removeWithoutEntryConsistencyCheck implementation. There are autotests for this code, that I can use?
Attachments
idea (543 bytes, patch)
2010-04-16 16:36 PDT, Jędrzej Nowacki 		ap: review-
jedrzej.nowacki: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-04-16 17:50:17 PDT
Comment on attachment 53579 [details] idea +#if CHECK_HASHTABLE_CONSISTENCY if (it.m_impl == m_impl.end()) return; +#endif What is the reason to keep this code when CHECK_HASHTABLE_CONSISTENCY is enabled? I don't know what the original idea for sharing responsibilities between HashSet and implementation classes was, but it seems more logical to remove the check from HashTable::removeWithoutEntryConsistencyCheck. All callers currently have it. > There are autotests for this code, that I can use? Regression tests for WebKit are executed by run-webkit-tests script, please see <http://webkit.org/coding/contributing.html> for more detail. r- for the lack of ChangeLog
Note You need to log in before you can comment on or make changes to this bug.