Bug 37728 - Setting media element 'src' attribute should trigger load immediately
Summary: Setting media element 'src' attribute should trigger load immediately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-04-16 13:48 PDT by Eric Carlson
Modified: 2010-04-19 16:07 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (18.72 KB, patch)
2010-04-16 14:51 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-04-16 13:48:18 PDT
The HTML5 spec used to require a script to call load() after changing the 'src' attribute, but it now says the change should be immediate. From section 4.8.9.2:

If a src attribute of a media element is set or changed, the user agent must 
invoke the media element's media element load algorithm. (Removing the 
src attribute does not do this, even if there are source elements present.)
Comment 1 Eric Carlson 2010-04-16 14:51:17 PDT
Created attachment 53567 [details]
proposed patch
Comment 2 Eric Carlson 2010-04-19 11:30:30 PDT
<rdar://problem/7879963>
Comment 3 Eric Carlson 2010-04-19 11:31:52 PDT
http://trac.webkit.org/changeset/57820
Comment 4 Eric Seidel (no email) 2010-04-19 11:55:43 PDT
Looks like this broke Tiger?
http://build.webkit.org/results/Tiger%20Intel%20Release/r57821%20(10961)/media/video-source-error-diffs.txt
Comment 5 WebKit Review Bot 2010-04-19 12:12:00 PDT
http://trac.webkit.org/changeset/57820 might have broken Leopard Intel Release (Tests)
Comment 6 Eric Seidel (no email) 2010-04-19 13:07:13 PDT
Actually, looks like this broke all versions of Mac besides Snow Leopard. :(
Comment 7 Eric Carlson 2010-04-19 13:14:55 PDT
http://trac.webkit.org/changeset/57830 should fix the regression.