Bug 37716 - WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile with minimal cofigured Qt
Summary: WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile wit...
Status: RESOLVED DUPLICATE of bug 37442
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Chang Shu
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-04-16 11:12 PDT by Chang Shu
Modified: 2010-04-19 06:40 PDT (History)
1 user (show)

See Also:

Attachments
fix patch (1.23 KB, patch)
2010-04-16 11:26 PDT, Chang Shu 		laszlo.gombos: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-04-16 11:12:20 PDT 
NotificationPresenterClientQt.h refers QSystemTrayIcon in qsystemtrayicon.h.
But QSystemTrayIcon is not declared with QT_NO_SYSTEMTRAYICON defined, which is true in minimal and small config of Qt.
Comment 1 Chang Shu 2010-04-16 11:26:24 PDT 
Created attachment 53544 [details]
fix patch
Comment 2 Laszlo Gombos 2010-04-18 21:32:59 PDT 
Comment on attachment 53544 [details]
fix patch

This patch would be more future-proof and would work in more build setups if test would check if QT_NO_SYSTEMTRAYICON is defined.

I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.
Comment 3 Laszlo Gombos 2010-04-18 21:33:39 PDT 

*** This bug has been marked as a duplicate of bug 37442 ***
Comment 4 Chang Shu 2010-04-19 06:40:26 PDT 
(In reply to comment #2)
> (From update of attachment 53544 [details])
> This patch would be more future-proof and would work in more build setups if
> test would check if QT_NO_SYSTEMTRAYICON is defined.
> 
> I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.

I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is defined.