WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 37442
37716
WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile with minimal cofigured Qt
https://bugs.webkit.org/show_bug.cgi?id=37716
Summary
WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile wit...
Chang Shu
Reported
2010-04-16 11:12:20 PDT
NotificationPresenterClientQt.h refers QSystemTrayIcon in qsystemtrayicon.h. But QSystemTrayIcon is not declared with QT_NO_SYSTEMTRAYICON defined, which is true in minimal and small config of Qt.
Attachments
fix patch
(1.23 KB, patch)
2010-04-16 11:26 PDT
,
Chang Shu
laszlo.gombos
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chang Shu
Comment 1
2010-04-16 11:26:24 PDT
Created
attachment 53544
[details]
fix patch
Laszlo Gombos
Comment 2
2010-04-18 21:32:59 PDT
Comment on
attachment 53544
[details]
fix patch This patch would be more future-proof and would work in more build setups if test would check if QT_NO_SYSTEMTRAYICON is defined. I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.
Laszlo Gombos
Comment 3
2010-04-18 21:33:39 PDT
*** This bug has been marked as a duplicate of
bug 37442
***
Chang Shu
Comment 4
2010-04-19 06:40:26 PDT
(In reply to
comment #2
)
> (From update of
attachment 53544
[details]
) > This patch would be more future-proof and would work in more build setups if > test would check if QT_NO_SYSTEMTRAYICON is defined. > > I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.
I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is defined.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug