At the WebKit meeting this past week Darin Adler pointed out that there are code sharing opportunities between the various WebGL<T>Array types. Some of these have been addressed with a recent refactoring to the range checking code, but more refactorings would be possible with a template base class between WebGLArray and the concrete types.
Created attachment 55562 [details]
From the ChangeLog:
No new tests; existing tests cover this functionality. Ran all WebGL layout tests in Safari and Chromium on Mac OS X.
Comment on attachment 55562 [details]
It would be great to either annotate each change or just remove this huge laundry list of files from the ChangeLog -- you already have refactoring described.
+ return adoptRef(new Subclass(buf, byteOffset, length));
(In reply to comment #2)
> (From update of attachment 55562 [details])
> It would be great to either annotate each change or just remove this huge laundry list of files from the ChangeLog -- you already have refactoring described.
Thanks for the feedback. I'm reluctant to remove the list of modified files / methods because other recent ChangeLog entries do the same thing, so I'm going to leave this as is.
> + return adoptRef(new Subclass(buf, byteOffset, length));
Committed r59085: <http://trac.webkit.org/changeset/59085>