Bug 37692 - [chromium] ignore IME events if the keydown event was prevented
Summary: [chromium] ignore IME events if the keydown event was prevented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-15 19:22 PDT by Tony Chang
Modified: 2010-05-18 19:33 PDT (History)
0 users

See Also:


Attachments
Patch (1.30 KB, patch)
2010-04-15 19:24 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2010-05-09 18:32 PDT, Tony Chang
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-04-15 19:22:13 PDT
[chromium] ignore IME events if the keydown event was prevented
Comment 1 Tony Chang 2010-04-15 19:24:55 PDT
Created attachment 53504 [details]
Patch
Comment 2 Tony Chang 2010-04-15 19:26:08 PDT
Discussion of this bug can be found http://code.google.com/p/chromium/issues/detail?id=9883 and a review by hbono and suzhe can be found http://codereview.chromium.org/1630015/show
Comment 3 Tony Chang 2010-04-15 19:27:18 PDT
Oh, and no layout test because I don't know how to test IME behavior changes.  I guess at some point we should build functionality into eventSender to send IME events.
Comment 4 Jian Li 2010-04-20 16:14:40 PDT
Comment on attachment 53504 [details]
Patch

Generally looks good. Do we have a layout test for this?
Comment 5 Tony Chang 2010-04-20 19:47:01 PDT
(In reply to comment #4)
> (From update of attachment 53504 [details])
> Generally looks good. Do we have a layout test for this?

Since posting comment #3, I learned about textInputController, so I tried to write a layout test.  However, this doesn't work since textInputController call methods directly on WebFrame and this check is in WebView.  I don't think it would make sense to move this check into WebFrame (since WebView knows about the state and does similar checks).

Maybe we could change textInputController.setMarkedText to call WebView::handleCompositionEvent instead, but that seems to deviate from DRT mac.  It's not clear to me that that's what we want either.
Comment 6 Eric Seidel (no email) 2010-05-08 23:28:52 PDT
Comment on attachment 53504 [details]
Patch

How do we test this?
Comment 7 Tony Chang 2010-05-09 18:32:49 PDT
Created attachment 55514 [details]
Patch
Comment 8 Tony Chang 2010-05-09 18:33:33 PDT
(In reply to comment #6)
> (From update of attachment 53504 [details])
> How do we test this?

Since I wasn't able to write a layout test for it, I've added a manual test.
Comment 9 Tony Chang 2010-05-18 19:33:19 PDT
Committed r59735: <http://trac.webkit.org/changeset/59735>