Bug 37680 – Please make sheriff bot generate more useful ChangeLogs for rollouts

• Status: NEW
• Component: Tools / Tests

[Alexey Proskuryakov]

Currently, there is no easy way to tell what change got reverted (other than reading the actual patch or clicking through links). I would like to be able to easily see it when something that was pompously landed disappears from the tree later. My most frequent use case is reading webkit-changes mail list.

Another common use case, as given by Maciej, is searching for a bug history in ChangeLogs: "By the way, just to explain why I ask for this: I often search ChangeLogs for the history of an issue, and searching for the bug number or obvious related text will not generally find entries where a change was rolled out. I would have to already know that the change was rolled out at some point, find the revision number of the original change, and then search for ChangeLog entries mentioning that revision number."

To cover both, ChangeLog should contain URL and title of the bug that had the original change. Maciej's proposal made on webkit-dev was:

- revision that was reverted
- bugzilla bug URL from the ChangeLog of the reverted commit (in a distinct format from how we'd provide it if it was the bug for the rollout change itself)
- summary text from the original revert

Something like:

- Reverted rNNNNN ("Rotate head 90 degrees clockwise")
<http://bugs.webkit.org/rollout-bug-num>

Reverted bug was: <http://bugs.webkit.org/bug-that-reverted>

[Adam Barth]

Created attachment 53517 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 53517 [details]
Patch

You look to be using the wrong bug_id in your message.  Your test case isn't very clear as to which is right and wrong.