Bug 37665 – [Qt] Rename QtLauncher to QtTestBrowser

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Rename QtLauncher to QtTestBrowser

[Simon Hausmann]

Created attachment 53455 [details]
Patch

[Simon Hausmann]

Created attachment 53461 [details]
Rename

[WebKit Review Bot]

Attachment 53461 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
6:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webpage.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/mainwindow.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/mainwindow.cpp
WebKitTools/QtTestBrowser/webinspector.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/useragentlist.txt
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/urlloader.h
WebKitTools/QtTestBrowser/webpage.cpp:33:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/webpage.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/urlloader.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/locationedit.cpp
WebKitTools/QtTestBrowser/main.cpp:33:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/main.cpp:67:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/QtTestBrowser/locationedit.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/mainwindow.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webview.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/utils.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webview.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/locationedit.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/QtLauncher.pro
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/QtLauncher.qrc
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/utils.h
WebKitTools/QtTestBrowser/utils.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/main.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webinspector.h
WebKitTools/QtTestBrowser/urlloader.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/urlloader.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webpage.h
WebKitTools/QtTestBrowser/webview.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/QtTestBrowser/webview.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 15 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 53461 [details]
Rename

rs=me

[WebKit Commit Bot]

Comment on attachment 53461 [details]
Rename

Rejecting patch 53461 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Antti Koivisto', '--force']" exit_code: 1
Last 500 characters of output:
Tools/QtLauncher/webview.cpp
rm 'WebKitTools/QtLauncher/webview.cpp'
patching file WebKitTools/QtLauncher/webview.h
rm 'WebKitTools/QtLauncher/webview.h'
patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro
patching file WebKitTools/QtTestBrowser/main.cpp
Hunk #1 succeeded at 1050 (offset 1 line).
Hunk #2 succeeded at 1069 (offset 1 line).
patching file WebKitTools/QtTestBrowser/useragentlist.txt
patching file WebKitTools/Scripts/run-launcher
patching file WebKitTools/Scripts/webkitdirs.pm

Full output: http://webkit-commit-queue.appspot.com/results/1792019

[Simon Hausmann]

Committed r59474: <http://trac.webkit.org/changeset/59474>

[Simon Hausmann]

Revision r59474 cherry-picked into qtwebkit-2.0 with commit 41b8115b256ed43acdf1976447925d5c1c6071a7

[Simon Hausmann]

Committed r59552: <http://trac.webkit.org/changeset/59552>