Bug 37660 - LayoutTest breakage in V8 bindings after r57627
Summary: LayoutTest breakage in V8 bindings after r57627
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-15 10:03 PDT by Justin Schuh
Modified: 2014-04-24 16:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2010-04-15 10:25 PDT, Justin Schuh 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Schuh 2010-04-15 10:03:25 PDT 
There's an error in V8NamedNodeMap::setNamedItemNSCallback() and V8NamedNodeMap::setNamedItemCallback() that's causing failures in the following tests after r57627:

hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html
Comment 1 Justin Schuh 2010-04-15 10:25:28 PDT 
Created attachment 53448 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-04-15 10:26:40 PDT 
Comment on attachment 53448 [details]
Patch

ok.
Comment 3 Albert J. Wong 2010-04-15 11:24:54 PDT 
Landed as r57658

Closing.
Comment 4 Darin Adler 2014-04-24 16:45:17 PDT 
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.