Bug 37659 - AXHelp is being appended from ancestors incorrectly
Summary: AXHelp is being appended from ancestors incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-15 09:22 PDT by chris fleizach
Modified: 2010-04-16 11:53 PDT (History)
6 users (show)

See Also:


Attachments
patch (9.58 KB, patch)
2010-04-15 09:40 PDT, chris fleizach
bdakin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-04-15 09:22:17 PDT
If an element is a child of a table with a summary, the element will use the table's summary as the help text, which is weird and wrong
Comment 1 chris fleizach 2010-04-15 09:40:06 PDT
Created attachment 53443 [details]
patch
Comment 2 WebKit Commit Bot 2010-04-15 10:16:56 PDT
Comment on attachment 53443 [details]
patch

Rejecting patch 53443 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12684 test cases.
platform/mac/accessibility/unexpected-help-text.html -> failed

Exiting early after 1 failures. 9417 tests run.
237.91s total testing time

9416 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
9 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1609520
Comment 3 chris fleizach 2010-04-15 10:37:43 PDT
did the commit-queue build this patch i wonder
Comment 4 chris fleizach 2010-04-15 14:06:14 PDT
http://trac.webkit.org/changeset/57674
Comment 5 WebKit Review Bot 2010-04-15 15:15:46 PDT
http://trac.webkit.org/changeset/57674 might have broken Tiger Intel Release and Leopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/57674
http://trac.webkit.org/changeset/57675
http://trac.webkit.org/changeset/57676
Comment 6 chris fleizach 2010-04-15 15:22:06 PDT
working on fix
Comment 7 James Robinson 2010-04-15 15:23:33 PDT
This seems to have broken all of the OS X Release bots:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20(Tests)/builds/12960/steps/layout-test/logs/stdio for example:
platform/mac/accessibility/unexpected-help-text.html -> failed

can you please fix or revert to get the bots green? Thanks
Comment 8 chris fleizach 2010-04-15 15:26:36 PDT
it only broke leopard and tiger.
Comment 9 James Robinson 2010-04-15 15:29:28 PDT
Yes, my bad.  Snow Leopard has a different failure currently.
Comment 10 chris fleizach 2010-04-15 15:31:19 PDT
this should do it
http://trac.webkit.org/changeset/57681
Comment 11 Eric Seidel (no email) 2010-04-16 11:48:12 PDT
The commit queue did build it. :)  And then rejected it due to a failing test. :)
Comment 12 chris fleizach 2010-04-16 11:53:29 PDT
yea, didn't realize which builder it was failing on and didn't realize that other tests would also fail. my fault