Bug 37642 – Use a lower-overhead mechanism for plug-in message throttling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Steve Falkenburg]

Use a lower-overhead mechanism for plug-in message throttling

[Steve Falkenburg]

Created attachment 53416 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 53416 [details]
Patch

> +        - The timer used to process the excess messages had a very low timeout (1ms).
> +          Other browsers use a value of 5ms for this delay.

You could say which "other browsers", for posterity's sake.

> +// Set a timer to make sure we process any queued messages at least every 16ms.
> +static const double MessageThrottleTimeInterval = 0.016;

It might be good to say (both here and in the ChangeLog) how 16ms was chosen.

> +// During a continuous stream of timers, process one every 5ms.
> +static const double MessageDirectProcessingInterval = 0.005;

I think you meant "stream of messages".

> @@ -74,11 +81,21 @@ void PluginMessageThrottlerWin::appendMe
>      if (!m_front)
>          m_front = message;
>  
> +    // If it has been more than MessageDirectProcessingInterval between throttled messages,
> +    // go ahead and process a message directly.
> +    double currentTime = WTF::currentTime();
> +    if (currentTime - m_lastMessageTime > MessageDirectProcessingInterval) {
> +        processQueuedMessage();
> +        m_lastMessageTime = currentTime;
> +        if (!m_front)
> +            return;
> +    }
> +

Seems like we should update m_lastMessageTime in processQueuedMessage() instead of here.

r=me

[Steve Falkenburg]

Thanks for review.

Resetting m_lastMessageTime is processQueuedMessage resulted in messages not being processed in the direct 5ms mode.

[Steve Falkenburg]

Committed r57650: <http://trac.webkit.org/changeset/57650>