Bug 37633 – Spatial Navigation: use a static var in maxDistance method ( SpatialNavigation.h )

• Status: RESOLVED
• Resolution: INVALID
• Component: Accessibility

[Antonio Gomes]

bug title says it all

ps: it is a minor, but good to get in

patch coming...

[Antonio Gomes]

Created attachment 53403 [details]
patch v1

[Antonio Gomes]

kenneth, could you sr that minor one?

[Antonio Gomes]

note: I am also ok with not getting this change in at all if we agree compilers are smart enough so that it is unneeded.

[Eric Seidel (no email)]

Comment on attachment 53403 [details]
patch v1

Seems like this makes no sense as an inline if you're doing this.

Why do we want this?  Is this a performance win?  numeric_limits<long long>::max() should already be a static lookup, no?

[Kenneth Rohde Christiansen]

(In reply to comment #4)
> (From update of attachment 53403 [details])
> Seems like this makes no sense as an inline if you're doing this.
> 
> Why do we want this?  Is this a performance win?  numeric_limits<long long>::max() should already be a static lookup, no?

I agree, this seems quite strange. Without data on performance improvements this will not be considered for inclusion.

[Antonio Gomes]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 53403 [details] [details])
> > Seems like this makes no sense as an inline if you're doing this.
> > 
> > Why do we want this?  Is this a performance win?  numeric_limits<long long>::max() should already be a static lookup, no?
> 
> I agree, this seems quite strange. Without data on performance improvements this will not be considered for inclusion.

At the time I made this small patch, I was questioning myself about it, and if it would be something that could get any better for the code, but I also agree it is fine as is, and that the change brings no logical win.