RESOLVED FIXED 37600
Windows Bots should kill old processes 
https://bugs.webkit.org/show_bug.cgi?id=37600
Summary Windows Bots should kill old processes
Brian Weinstein
Reported 2010-04-14 13:11:06 PDT
Windows Bots should kill old processes
Attachments
Kill Old Processes (4.56 KB, patch)
2010-04-14 13:14 PDT, Brian Weinstein 		aroben: review+
bweinstein: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2010-04-14 13:14:39 PDT
Created attachment 53358 [details] Kill Old Processes
Adam Roben (:aroben)
Comment 2 2010-04-14 13:19:53 PDT
Comment on attachment 53358 [details] Kill Old Processes > Index: WebKitTools/BuildSlaveSupport/kill-old-processes-win How about win/kill-old-processes instead? > +def main(): > + os.system("taskkill /f /im DumpRenderTree.exe") > + os.system("taskkill /f /im DumpRenderTree_debug.exe") > + os.system("taskkill /f /im testapi.exe") > + os.system("taskkill /f /im testapi_debug.exe") > + os.system("taskkill /f /im svn.exe") > + os.system("taskkill /f /im httpd.exe") > + os.system("taskkill /f /im cl.exe") > + os.system("taskkill /f /im link.exe") > + os.system("taskkill /f /im midl.exe") > + os.system("taskkill /f /im devenv.exe") > + os.system("taskkill /f /im perl.exe") > + os.system("taskkill /f /im imagediff.exe") Can we have an array of all the process names we want to kill, and then loop over the array? You should kill imagediff_debug.exe, jsc.exe, and jsc_debug.exe, too. r=me
Brian Weinstein
Comment 3 2010-04-14 13:31:22 PDT
(In reply to comment #2) > (From update of attachment 53358 [details]) > > Index: WebKitTools/BuildSlaveSupport/kill-old-processes-win > > How about win/kill-old-processes instead? Fixed. > > > +def main(): > > + os.system("taskkill /f /im DumpRenderTree.exe") > > + os.system("taskkill /f /im DumpRenderTree_debug.exe") > > + os.system("taskkill /f /im testapi.exe") > > + os.system("taskkill /f /im testapi_debug.exe") > > + os.system("taskkill /f /im svn.exe") > > + os.system("taskkill /f /im httpd.exe") > > + os.system("taskkill /f /im cl.exe") > > + os.system("taskkill /f /im link.exe") > > + os.system("taskkill /f /im midl.exe") > > + os.system("taskkill /f /im devenv.exe") > > + os.system("taskkill /f /im perl.exe") > > + os.system("taskkill /f /im imagediff.exe") > > Can we have an array of all the process names we want to kill, and then loop > over the array? Sure, done. > > You should kill imagediff_debug.exe, jsc.exe, and jsc_debug.exe, too. Done. Thanks! > > r=me
Brian Weinstein
Comment 4 2010-04-14 13:33:04 PDT
Landed in r57602.
Note You need to log in before you can comment on or make changes to this bug.