Bug 37595 - Implement layoutTestController's addUserStyleSheet and setAuthorAndUserStylesEnabled on Chromium port
Summary: Implement layoutTestController's addUserStyleSheet and setAuthorAndUserStyles...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Matt Perry
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-14 12:29 PDT by Matt Perry
Modified: 2010-04-15 18:00 PDT (History)
3 users (show)

See Also:

Attachments
simple patch that adds the given methods to the WebKit API (4.59 KB, patch)
2010-04-14 12:34 PDT, Matt Perry 		no flags Details | Formatted Diff | Diff
fix style issues (4.60 KB, patch)
2010-04-14 12:44 PDT, Matt Perry 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Perry 2010-04-14 12:29:42 PDT 
In order to fix a couple failing layout tests, we need to implement some missing methods for the Chromium port.
Comment 1 Matt Perry 2010-04-14 12:34:37 PDT 
Created attachment 53351 [details]
simple patch that adds the given methods to the WebKit API
Comment 2 WebKit Review Bot 2010-04-14 12:36:27 PDT 
Attachment 53351 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:1889:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKit/chromium/src/WebSettingsImpl.cpp:188:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Matt Perry 2010-04-14 12:44:58 PDT 
Created attachment 53354 [details]
fix style issues
Comment 4 Dirk Pranke 2010-04-15 12:38:09 PDT 
drive-by LGTM (but I'm not a reviewer).
Comment 5 Dimitri Glazkov (Google) 2010-04-15 13:58:39 PDT 
Comment on attachment 53354 [details]
fix style issues

ok.
Comment 6 WebKit Commit Bot 2010-04-15 18:00:37 PDT 
Comment on attachment 53354 [details]
fix style issues

Clearing flags on attachment: 53354

Committed r57699: <http://trac.webkit.org/changeset/57699>
Comment 7 WebKit Commit Bot 2010-04-15 18:00:41 PDT 
All reviewed patches have been landed.  Closing bug.