Bug 37587 – new-run-webkit-tests: try to detect alternate apache path

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tor Arne Vestbø]

new-run-webkit-tests: try to detect alternate apache path

[Tor Arne Vestbø]

Created attachment 53345 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 53345 [details]
Patch

Seems reasonable.  We should add a comment about why we have to detect multiple apaches.

Also, it seems like we might want to cache this information so we're not stating the file repeatedly?

[Tor Arne Vestbø]

Created attachment 53356 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 53356 [details]
Patch

Fantastic!

[WebKit Commit Bot]

Comment on attachment 53356 [details]
Patch

Rejecting patch 53356 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53356', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
', 'commit', '--all', '-F', '-'], input=message)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command
    return Executive().run_command(*args, **kwargs)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command
    string_to_communicate = str(input)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 26: ordinal not in range(128)

[Eric Seidel (no email)]

I think I know how to fix this now.

We can use codec.encode(input, "latin1") (or some variant) to encode the utf-8 down to latin1 w/o exception before passing to to the subprocess?

[Eric Seidel (no email)]

Actually, I mispoke.  We likely want to encode the python unicode object into utf8 to feed to our subproccess.

[Eric Seidel (no email)]

Sorry.  If bug 37765 isn't landed today, I'll land this change by hand.

[Eric Seidel (no email)]

Comment on attachment 53356 [details]
Patch

Sorry again for the trouble.

[Eric Seidel (no email)]

Comment on attachment 53356 [details]
Patch

The fix for bug 37765 was rolled out.  So this will fail to land.  Hopefully I'll reland the fix tomorrow at which point I'll cq+ this again.

[Eric Seidel (no email)]

Comment on attachment 53356 [details]
Patch

Clearing flags on attachment: 53356

Committed r57964: <http://trac.webkit.org/changeset/57964>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.