WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
37586
fix new-run-webkit-tests to fit in 80 columns
https://bugs.webkit.org/show_bug.cgi?id=37586
Summary
fix new-run-webkit-tests to fit in 80 columns
Dirk Pranke
Reported
2010-04-14 11:03:31 PDT
For full PEP-8 compliance all of our Python code should fit in 80 columns (see
bug 37477
).
Attachments
patch
(21.72 KB, patch)
2010-04-14 16:50 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-04-14 11:41:23 PDT
I don't think we want this. The rest of WebKit code doesn't wrap to 80 columns. I don't think complying with pep8/E501 really buys us anything except confusion.
Dirk Pranke
Comment 2
2010-04-14 16:50:52 PDT
Created
attachment 53384
[details]
patch
Adam Barth
Comment 3
2010-04-14 21:00:34 PDT
Comment on
attachment 53384
[details]
patch At the risk of getting yelled at by Eric, I'm r+ing this change. In general, I think the 80c is the least important of the style rules, but what can you do?
Dirk Pranke
Comment 4
2010-04-15 14:02:09 PDT
Comment on
attachment 53384
[details]
patch Clearing flags on attachment: 53384 Committed
r57673
: <
http://trac.webkit.org/changeset/57673
>
Dirk Pranke
Comment 5
2010-04-15 14:02:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug