Bug 37582 - Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
Summary: Web Inspector: Console: Shift-Tab does not cycle autocompletions in the rever...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
Depends on:
Reported: 2010-04-14 09:41 PDT by Alexander Pavlov (apavlov)
Modified: 2010-04-14 11:42 PDT (History)
8 users (show)

See Also:

[PATCH] Suggested solution (3.00 KB, patch)
2010-04-14 09:57 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-04-14 09:41:38 PDT
When Shift is depressed, Tab cycles autocompletion suggestions in the forward direction rather than reverse.
Comment 1 Alexander Pavlov (apavlov) 2010-04-14 09:57:31 PDT
Created attachment 53340 [details]
[PATCH] Suggested solution
Comment 2 Joseph Pecoraro 2010-04-14 10:27:32 PDT
Looks good! I just noticed this was missing the other day, glad to see you add
it =) [Collision: I agree with Tim's r+]

> +            var nextIndex = foundIndex + (reverse ? -1 : 1);

I haven't seen a case where we use (null + #) but this works fine in JavaScript
and the code is pretty clean here.

> +        this.complete(false, event.shiftKey);

Is just event.shiftKey enough? Do you feel that we should say something
stronger like this:

    event.shiftKey && !event.ctrlKey && !event.metaKey

TextMate for example allows Shift+Esc to go back through a list but not
Shift+Ctrl+Esc or Shift+Alt+Esc. Apparently Safari / OS X captures these
combinations and handles other actions, but it could be possible that other
platforms would let such a combination through. Either way, I think this is
unlikely to occur, but something to think about.
Comment 3 WebKit Commit Bot 2010-04-14 11:42:20 PDT
Comment on attachment 53340 [details]
[PATCH] Suggested solution

Clearing flags on attachment: 53340

Committed r57592: <http://trac.webkit.org/changeset/57592>
Comment 4 WebKit Commit Bot 2010-04-14 11:42:26 PDT
All reviewed patches have been landed.  Closing bug.