Bug 37575 - RenderSVGResource <-> id mapping should be cached
Summary: RenderSVGResource <-> id mapping should be cached
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 36564
  Show dependency treegraph
 
Reported: 2010-04-14 08:09 PDT by Nikolas Zimmermann
Modified: 2010-04-15 12:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch (26.62 KB, patch)
2010-04-15 05:56 PDT, Nikolas Zimmermann
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-04-14 08:09:07 PDT
RenderSVGResource looku
To lookup RenderSVGResources for a certain RenderObject, we're using getElementById, which has been identified as a bottle-neck.
We discussed to cache RenderSVGResource pointers in the SVGRenderStyle, though that's dangerous, as we have to be sure we're not referencing dangling pointers.

So I'll propose a HashMap<String, RenderSVGresource*> addition in SVGDocumentExtensions. Patch following.
Comment 1 Nikolas Zimmermann 2010-04-15 05:56:32 PDT
Created attachment 53426 [details]
Patch
Comment 2 Nikolas Zimmermann 2010-04-15 11:33:09 PDT
Committed r57659: <http://trac.webkit.org/changeset/57659>
Comment 3 WebKit Review Bot 2010-04-15 12:03:53 PDT
http://trac.webkit.org/changeset/57659 might have broken Qt Linux Release minimal