WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 37575
RenderSVGResource <-> id mapping should be cached
https://bugs.webkit.org/show_bug.cgi?id=37575
Summary
RenderSVGResource <-> id mapping should be cached
Nikolas Zimmermann
Reported
2010-04-14 08:09:07 PDT
RenderSVGResource looku To lookup RenderSVGResources for a certain RenderObject, we're using getElementById, which has been identified as a bottle-neck. We discussed to cache RenderSVGResource pointers in the SVGRenderStyle, though that's dangerous, as we have to be sure we're not referencing dangling pointers. So I'll propose a HashMap<String, RenderSVGresource*> addition in SVGDocumentExtensions. Patch following.
Attachments
Patch
(26.62 KB, patch)
2010-04-15 05:56 PDT
,
Nikolas Zimmermann
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2010-04-15 05:56:32 PDT
Created
attachment 53426
[details]
Patch
Nikolas Zimmermann
Comment 2
2010-04-15 11:33:09 PDT
Committed
r57659
: <
http://trac.webkit.org/changeset/57659
>
WebKit Review Bot
Comment 3
2010-04-15 12:03:53 PDT
http://trac.webkit.org/changeset/57659
might have broken Qt Linux Release minimal
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug