Bug 37568 - SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
Summary: SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P4 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2010-04-14 02:03 PDT by Nikolas Zimmermann
Modified: 2010-04-14 03:44 PDT (History)
5 users (show)

See Also:

Patch (46.98 KB, patch)
2010-04-14 02:12 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch (49.26 KB, patch)
2010-04-14 03:14 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-04-14 02:03:25 PDT
SVGRenderStyle(Defs) is old legacy code and needs to be cleaned up.
While I'm at it, we could save memory be joining StyleMaskData/StyleClipData in a single StyleResourceData. For consistency StyleMarkerData will be named StyleInheritedResourceData.
All naming schemes should be unified for clipper / masker / marker / filter, see the upcoming patch.
Comment 1 Nikolas Zimmermann 2010-04-14 02:12:50 PDT
Created attachment 53323 [details]
Comment 2 WebKit Review Bot 2010-04-14 02:54:48 PDT
Attachment 53323 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1602462
Comment 3 WebKit Review Bot 2010-04-14 03:13:25 PDT
Attachment 53323 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1671314
Comment 4 Nikolas Zimmermann 2010-04-14 03:14:21 PDT
Created attachment 53325 [details]
Comment 5 Nikolas Zimmermann 2010-04-14 03:15:50 PDT
Updated patch against trunk, was missing RenderSVGResourceClipper changes after Dirks commit.
Comment 6 Dirk Schulze 2010-04-14 03:40:14 PDT
Comment on attachment 53325 [details]

LGTM r=me
Comment 7 Nikolas Zimmermann 2010-04-14 03:44:52 PDT
Committed r57575: <http://trac.webkit.org/changeset/57575>