RESOLVED INVALID 37531
Dummy bug for testing code review tool.
https://bugs.webkit.org/show_bug.cgi?id=37531
Summary Dummy bug for testing code review tool.
Julie Parent
Reported 2010-04-13 16:42:56 PDT
This is just a test bug for testing reitveld integration. Don't worry, I am only making one fake bug.
Attachments
Dummy patch. (920 bytes, patch)
2010-04-13 16:43 PDT, Julie Parent
no flags
Patch (701 bytes, patch)
2010-04-15 14:07 PDT, Ojan Vafai
no flags
Patch (701 bytes, patch)
2010-04-15 14:10 PDT, Ojan Vafai
no flags
Patch-4001 (2.09 KB, patch)
2010-04-15 14:27 PDT, Ojan Vafai
no flags
Patch-5001 (750 bytes, patch)
2010-04-16 16:25 PDT, Ojan Vafai
no flags
Julie Parent
Comment 1 2010-04-13 16:43:39 PDT
Created attachment 53298 [details] Dummy patch.
Julie Parent
Comment 2 2010-04-13 16:57:22 PDT
Comment on attachment 53298 [details] Dummy patch. testing
Julie Parent
Comment 3 2010-04-14 15:22:24 PDT
Comment on attachment 53298 [details] Dummy patch. > > > > > setTimeout(function() { > var codeViewFrame = document.getElementsByTagName('frame')[0]; > var reviewFrame = document.getElementsByTagName('frame')[1]; > var reviewDoc = reviewFrame.contentDocument; > > // Add button for showing Reitveld. > var prettyPatchButton = reviewDoc.getElementById('viewPrettyPatchButton'); > var awesomeButton = reviewDoc.createElement('input'); > awesomeButton.type = 'button'; > awesomeButton.id = 'reitveldBtn'; > awesomeButton.value = 'View in Reitveld'; > awesomeButton.onclick = navToReitveld; > prettyPatchButton.parentNode.appendChild(awesomeButton); > > function navToReitveld() { > // TODO: Get real URL here. > codeViewFrame.location = 'http://wkrietveld.appspot.com/'; > } > > function updateComments() { > // Hook into submit action, get data from reitveld. > var commentField = reviewDoc.getElementById('comment'); > var comments = > commentField.value = comments; > } > > }, 1000);
Julie Parent
Comment 4 2010-04-14 15:39:25 PDT
Comment on attachment 53298 [details] Dummy patch. foo@bar.com
Julie Parent
Comment 5 2010-04-15 13:57:22 PDT
Comment on attachment 53298 [details] Dummy patch. http://wkrietveld.appspot.com/2001/diff/1/2 File templates/patch.html (right): http://wkrietveld.appspot.com/2001/diff/1/2#newcode162 templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!") THIS IS NEW! On 2010/04/15 20:52:36, contributor wrote: > On 2010/04/15 20:50:48, contributor wrote: > > On 2010/04/15 20:41:55, contributor wrote: > > > This line is too long. > > > > Done. > > Done.
Julie Parent
Comment 6 2010-04-15 14:00:41 PDT
Comment on attachment 53298 [details] Dummy patch. http://wkrietveld.appspot.com/2001/diff/1/2 File templates/patch.html (right): http://wkrietveld.appspot.com/2001/diff/1/2#newcode162 templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!") This is awesome! On 2010/04/15 20:57:21, contributor wrote: > THIS IS NEW! > > On 2010/04/15 20:52:36, contributor wrote: > > On 2010/04/15 20:50:48, contributor wrote: > > > On 2010/04/15 20:41:55, contributor wrote: > > > > This line is too long. > > > > > > Done. > > > > Done. > >
Ojan Vafai
Comment 7 2010-04-15 14:07:46 PDT
Ojan Vafai
Comment 8 2010-04-15 14:10:16 PDT
Created attachment 53476 [details] Patch Feel free to provide comments at https://wkrietveld.appspot.com/3001
Ojan Vafai
Comment 9 2010-04-15 14:27:06 PDT
Created attachment 53478 [details] Patch-4001 Feel free to provide comments at https://wkrietveld.appspot.com/4001
Julie Parent
Comment 10 2010-04-16 11:50:45 PDT
Comment on attachment 53478 [details] Patch-4001 My comments from here ------------------------------------------------------------------ http://wkrietveld.appspot.com/4001/diff/1/4 File WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py (right): http://wkrietveld.appspot.com/4001/diff/1/4#newcode4 WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py:4: # modification, are permitted provided that the following conditions are Wot?
David Levin
Comment 11 2010-04-16 11:53:56 PDT
Comment on attachment 53478 [details] Patch-4001 test ------------------------------------------------------------------
Ojan Vafai
Comment 12 2010-04-16 16:25:26 PDT
Created attachment 53577 [details] Patch-5001
Note You need to log in before you can comment on or make changes to this bug.