Bug 37500 – [Gtk] Fix leaking the FontPlatformData instance used to create the the small caps font data.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Stephan Aßmus]

WebCore::SimpleFontData::smallCapsFontData() is allocating a FontPlatformData object on the heap and assigns it to a const pointer and never frees it. The FontPlatformData is used for assigning the member of the same type in a SimpleFontData object. Usually, ports implement the data of FontPlatformData to be reference counted, and the instance in SimpleFontData takes over the ownership (same in the Gtk port). The Haiku port contained the same problem initially, that's why I spotted it when cross referencing the Gtk port.

[Stephan Aßmus]

Created attachment 53243 [details]
Patch to fix the problem

[Holger Freyther]

Comment on attachment 53243 [details]
Patch to fix the problem

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 57513)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> [phone]  Stephan AÃmus  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Gtk] Fix leaking the FontPlatformData instance used to create the the
> +        small caps font data.
> +        https://bugs.webkit.org/show_bug.cgi?id=37500
> +
> +        No new tests needed.
> +
> +        * platform/graphics/gtk/SimpleFontDataPango.cpp:
> +        (WebCore::SimpleFontData::smallCapsFontData):
> +            - Use a stack allocated FontPlatformData instead of a heap allocated
> +              one that is never freed.

Thanks a lot!

[Holger Freyther]

 git grep "const FontPlatformData\* pdata = new" WebCore/platform/graphics/
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:        const FontPlatfo
WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp:        const FontPlatform
WebCore/platform/graphics/wx/SimpleFontDataWx.cpp: 

so, we need to fix these two as well.

[WebKit Commit Bot]

Comment on attachment 53243 [details]
Patch to fix the problem

Clearing flags on attachment: 53243

Committed r58679: <http://trac.webkit.org/changeset/58679>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.