Bug 37498 – Web Inspector: in Profiles panel, search always displays "Not found", although it jumps through the results

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

Created attachment 53240 [details]
Sample of search box incorrect bheavior

Open Inspector, enable profiling, and collect a profile.

In the "Search Profiles" field, try to search for something existing, e.g. "(program)" or "(idle)". To the left of the box "Not Found" is displayed immediately. Interesting enough, that switching back and forth between panels (or between profile views), and then pressing "Enter" on the search box sometimes leads to showing search results and cursor jumping over them, but "Not Found" is still displayed (see the screenshot.)

[Mikhail Naganov]

Created attachment 53246 [details]
proposed patch

[Pavel Feldman]

Comment on attachment 53246 [details]
proposed patch

> +        // The profile passed in the constructor contains important properties, but
> +        // no actual data. To have both properties and data, we chain the profile
> +        // we've got from 'getProfile' with the one passed in the constructor.
> +        profile.__proto__ = self.profile;

Assigning proto is nothing but the hack. What you should do is to create an object with properties around the payload you've received just as it is done in case of DOMAgent.js.

[Mikhail Naganov]

Created attachment 53264 [details]
comments addressed

[Pavel Feldman]

Comment on attachment 53264 [details]
comments addressed

Much better!

[WebKit Commit Bot]

Comment on attachment 53264 [details]
comments addressed

Clearing flags on attachment: 53264

Committed r57529: <http://trac.webkit.org/changeset/57529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.