Bug 37496 – Add URL scheme parsing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Add URL scheme parsing tests

[Adam Barth]

Created attachment 53231 [details]
Patch

[Alexey Proskuryakov]

Could it be correct behavior that " HTTP " is treated as a relative URL? Maybe it should never hit the "absolute URL" case, in fact?

[Adam Barth]

> Could it be correct behavior that " HTTP " is treated as a relative URL? Maybe
> it should never hit the "absolute URL" case, in fact?

Yes, I believe that is the correct behavior.  However, it makes it tricky to test how we parse absolute URLs that begin in this way.

[Alexey Proskuryakov]

That would mean testing a code path that should never be taken. It seems better to just test that this code path is never taken by verifying that such URLs are parsed as relative.

[Adam Barth]

> That would mean testing a code path that should never be taken.

There might be another API that takes strings and parses them as absolute URLs, or if there isn't one today, we could well invent one tomorrow.

> It seems better
> to just test that this code path is never taken by verifying that such URLs are
> parsed as relative.

We can certainly test that if you like.  The intent of this test is to test the URL parser, not the HTMLAnchorElement.href API.  We're just using the href API as a convenient way to get at the URL parser.

[Maciej Stachowiak]

Comment on attachment 53231 [details]
Patch

r=me

[Adam Barth]

Committed r57635: <http://trac.webkit.org/changeset/57635>