Bug 37490 - Add URL anchor tests from Google URL
Summary: Add URL anchor tests from Google URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 22:24 PDT by Daniel Bates
Modified: 2010-04-12 23:09 PDT (History)
2 users (show)

See Also:


Attachments
Layout Test (3.55 KB, patch)
2010-04-12 22:26 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-04-12 22:24:42 PDT
We should implement the URL anchor tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.
Comment 1 Daniel Bates 2010-04-12 22:26:36 PDT
Created attachment 53223 [details]
Layout Test
Comment 2 Adam Barth 2010-04-12 22:56:28 PDT
Comment on attachment 53223 [details]
Layout Test

Thanks Dan.  I'm not sure we're doing the crazy charset ones correctly.  We might need to set the charset for the page to UTF8.  Do these pass in Chrome?  Another possibility (actually, this is more likely) is that we need to find the UTF16 codepoints for these character.  Maybe use the ones from the L strings?
Comment 3 WebKit Commit Bot 2010-04-12 23:09:46 PDT
Comment on attachment 53223 [details]
Layout Test

Clearing flags on attachment: 53223

Committed r57502: <http://trac.webkit.org/changeset/57502>
Comment 4 WebKit Commit Bot 2010-04-12 23:09:51 PDT
All reviewed patches have been landed.  Closing bug.