Bug 37484 - new-run-webkit-tests: path_from_chromium_base Chromium hacks are sprinkled throughout win32 codepath
Summary: new-run-webkit-tests: path_from_chromium_base Chromium hacks are sprinkled th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 21:14 PDT by Eric Seidel (no email)
Modified: 2011-04-01 16:27 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-12 21:14:06 PDT
path_from_chromium_base Chromium hacks are sprinkled throughout new-run-webkit-tests win32 codepath

This blocks the WebKit Win port from working.

For now I think we should just hack around them with a few "if options.chromium" checks.
Comment 1 Eric Seidel (no email) 2010-04-12 21:14:36 PDT
Example hack:

        # Put the cygwin directory first in the path to find cygwin1.dll
        env = os.environ
        if sys.platform in ('cygwin', 'win32'):
            env['PATH'] = '%s;%s' % (
                self._port_obj.path_from_chromium_base('third_party',
                                                       'cygwin', 'bin'),
                env['PATH'])

        if sys.platform == 'win32' and self._register_cygwin:
            setup_mount = self._port_obj.path_from_chromium_base('third_party',
                'cygwin', 'setup_mount.bat')
            subprocess.Popen(setup_mount).wait()
Comment 2 Eric Seidel (no email) 2010-04-12 21:15:53 PDT
I think it's more that the http_server.py module doesn't really use the port infrastructure yet.
Comment 3 Dirk Pranke 2011-04-01 16:27:49 PDT
This only calls to that method I see now are from the port/chromium*.py files,  and it looks like they are all there legitimately to deal with downstream expectations, results, or builds. 

I'm guessing someone (me?) must've cleaned this up at some point in the path. Please reopen or file a new bug if you see any other issues.