We should implement at least all of the non-encoding specific query string tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.
Created attachment 53214 [details] Layout Test
Comment on attachment 53214 [details] Layout Test +<script src="resources/utilities.js"></script> I don't think we can edit these files because they are generated from the make-test-wrappers script. + ["as#df", "as%23df"], I don't think this result is correct, but I agree that we should just literally land what's in the unit tests. We can do a separate pass to understand the different behaviors here. Review- because we can't change the generated files. I think it's ok to copy/paste that small function between tests.
(In reply to comment #2) > (From update of attachment 53214 [details]) > +<script src="resources/utilities.js"></script> > > I don't think we can edit these files because they are generated from the > make-test-wrappers script. I added the external JavaScript file to the TEMPLATE.html file. So, when you run make-script-test-wrappers, it will generate ipv4.html, trivial.html, and query.html with this external JavaScript. > > + ["as#df", "as%23df"], > > I don't think this result is correct, but I agree that we should just literally > land what's in the unit tests. We can do a separate pass to understand the > different behaviors here. Yes, I was skeptical about this as well being valid. I can remove it.
Comment on attachment 53214 [details] Layout Test I stand corrected. You are awesome. Let's leave the test in. I'd like to do a pass through the whole test suite once we've got it checked in.
Comment on attachment 53214 [details] Layout Test Clearing flags on attachment: 53214 Committed r57501: <http://trac.webkit.org/changeset/57501>
All reviewed patches have been landed. Closing bug.
Tip for the follow up pass: you can use http://rishida.net/tools/conversion/ to do the character set conversion utf 8 -> utf 16, e.g. q=\xe4\xbd\xa0\xe5\xa5\xbd translates to q=\u4F60\u597D in JS escaping. (i.e. enter "e4 bd a0 e5 a5 bd" into the UTF-8 code units box)
Sweet!