Bug 37476 - Add some ip4v tests (will revise in a minute)
Summary: Add some ip4v tests (will revise in a minute)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 17:04 PDT by Adam Barth
Modified: 2010-04-12 21:53 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.74 KB, patch)
2010-04-12 17:05 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2010-04-12 17:11 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-12 17:04:56 PDT
Add some ip4v tests (will revise in a minute)
Comment 1 Adam Barth 2010-04-12 17:05:23 PDT
Created attachment 53200 [details]
Patch
Comment 2 Adam Barth 2010-04-12 17:11:10 PDT
Created attachment 53201 [details]
Patch
Comment 3 Adam Barth 2010-04-12 17:12:01 PDT
Committed r57489: <http://trac.webkit.org/changeset/57489>
Comment 4 Daniel Bates 2010-04-12 19:30:05 PDT
> +  ["192.168.0.1", "192.168.0.1"],
> +  ["", ""],
> +  [".", ""],
> +  ["192.168.0.1", "192.168.0.1"],

You have the entry ["192.168.0.1", "192.168.0.1"] twice in the case array as well as the corresponding result in the file /ipv4-expected.txt.
Comment 5 Adam Barth 2010-04-12 20:19:19 PDT
> You have the entry ["192.168.0.1", "192.168.0.1"] twice in the case array as
> well as the corresponding result in the file /ipv4-expected.txt.

Thanks.  I need to fix finish these tests.  I just wanted to get them in the tree so other folks could use the harness.