Bug 37473 - WebKit should have more robust last-chance font fallback on Windows
Summary: WebKit should have more robust last-chance font fallback on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 16:15 PDT by Steve Falkenburg
Modified: 2010-04-12 17:48 PDT (History)
0 users

See Also:

Attachments
Patch (5.56 KB, patch)
2010-04-12 16:41 PDT, Steve Falkenburg 		no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2010-04-12 16:45 PDT, Steve Falkenburg 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-04-12 16:15:18 PDT 
WebKit should have more robust last-chance font fallback on Windows
Comment 1 Steve Falkenburg 2010-04-12 16:41:12 PDT 
Created attachment 53198 [details]
Patch
Comment 2 Steve Falkenburg 2010-04-12 16:45:22 PDT 
Created attachment 53199 [details]
Patch
Comment 3 mitz 2010-04-12 17:00:12 PDT 
Comment on attachment 53199 [details]
Patch

> +#if PLATFORM(WIN)
> +    SimpleFontData* FontCache::fontDataFromDescriptionAndLogFont(const FontDescription&, const LOGFONT&);
> +#endif

I’d avoid this method and replace it with a file-static function that takes a FontCache*, but r=me either way.
Comment 4 Steve Falkenburg 2010-04-12 17:48:14 PDT 
Committed r57490: <http://trac.webkit.org/changeset/57490>