Bug 37464 - new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
: new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-04-12 13:15 PST by
Modified: 2010-04-12 16:15 PST (History)


Attachments
Patch (4.02 KB, patch)
2010-04-12 14:13 PST, Dirk Pranke
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-04-12 13:15:30 PST
Current the run_webkit_tests.py script used by new-run-webkit-tests to do all the real work calls sys.exit(). This makes it difficult to call the functions repeatedly for unit testing, and is kind of a goofy layering violation.

The exit call should be pushed up into the main new-run-webkit-tests script.
------- Comment #1 From 2010-04-12 14:13:43 PST -------
Created an attachment (id=53186) [details]
Patch
------- Comment #2 From 2010-04-12 16:06:38 PST -------
(From update of attachment 53186 [details])
OK.
------- Comment #3 From 2010-04-12 16:15:17 PST -------
(From update of attachment 53186 [details])
Clearing flags on attachment: 53186

Committed r57486: <http://trac.webkit.org/changeset/57486>
------- Comment #4 From 2010-04-12 16:15:23 PST -------
All reviewed patches have been landed.  Closing bug.