WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
37464
new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
https://bugs.webkit.org/show_bug.cgi?id=37464
Summary
new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
Dirk Pranke
Reported
2010-04-12 13:15:30 PDT
Current the run_webkit_tests.py script used by new-run-webkit-tests to do all the real work calls sys.exit(). This makes it difficult to call the functions repeatedly for unit testing, and is kind of a goofy layering violation. The exit call should be pushed up into the main new-run-webkit-tests script.
Attachments
Patch
(4.02 KB, patch)
2010-04-12 14:13 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2010-04-12 14:13:43 PDT
Created
attachment 53186
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-04-12 16:06:38 PDT
Comment on
attachment 53186
[details]
Patch OK.
Dirk Pranke
Comment 3
2010-04-12 16:15:17 PDT
Comment on
attachment 53186
[details]
Patch Clearing flags on attachment: 53186 Committed
r57486
: <
http://trac.webkit.org/changeset/57486
>
Dirk Pranke
Comment 4
2010-04-12 16:15:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug