Bug 37464 - new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
Summary: new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 13:15 PDT by Dirk Pranke
Modified: 2010-04-12 16:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2010-04-12 14:13 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-12 13:15:30 PDT 
Current the run_webkit_tests.py script used by new-run-webkit-tests to do all the real work calls sys.exit(). This makes it difficult to call the functions repeatedly for unit testing, and is kind of a goofy layering violation.

The exit call should be pushed up into the main new-run-webkit-tests script.
Comment 1 Dirk Pranke 2010-04-12 14:13:43 PDT 
Created attachment 53186 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-12 16:06:38 PDT 
Comment on attachment 53186 [details]
Patch

OK.
Comment 3 Dirk Pranke 2010-04-12 16:15:17 PDT 
Comment on attachment 53186 [details]
Patch

Clearing flags on attachment: 53186

Committed r57486: <http://trac.webkit.org/changeset/57486>
Comment 4 Dirk Pranke 2010-04-12 16:15:23 PDT 
All reviewed patches have been landed.  Closing bug.