Bug 37461 - Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
Summary: Spatial Navigation: make renderRectRelativeToRootDocument method to fallback ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
Depends on: 18662
Blocks: 35784 36463
  Show dependency treegraph
Reported: 2010-04-12 12:13 PDT by Antonio Gomes
Modified: 2010-04-20 13:21 PDT (History)
3 users (show)

See Also:

(committed in r57496) patch v1 (6.71 KB, patch)
2010-04-12 12:57 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-04-12 12:13:54 PDT
As discussed in [1], renderer's absoluteClippedOverflowRect() method can return an empty IntRect when node() of renderer is offscreen.

For this case, make spatial navigation to fallback to getRect of Element instead.

[1] http://old.nabble.com/AbsoluteClippedOverflowRect-return-empty-IntRect-td28005341.html
Comment 1 Antonio Gomes 2010-04-12 12:57:08 PDT
Created attachment 53182 [details]
(committed in r57496) patch v1

fallback to getRect method Element when absoluteClippedOverflowRect of RenderObject returns a empty rect.
Comment 2 Antonio Gomes 2010-04-12 19:49:48 PDT
Comment on attachment 53182 [details]
(committed in r57496) patch v1

(From update of attachment 53182 [details])
Clearing flags on attachment: 53182

Committed r57496: <http://trac.webkit.org/changeset/57496>
Comment 3 Antonio Gomes 2010-04-12 19:50:51 PDT
Thank you Simon Fraser!!!
Comment 4 Simon Hausmann 2010-04-20 13:21:29 PDT
Revision r57496 cherry-picked into qtwebkit-2.0 with commit 7d5c02b80c68d5cebe067bd0968b7dc9b6a12e92