Bug 37448 - Web Inspector: Replace hand-written profiler bindings with idl-based, [Chromium] plug in new JSC-aligned V8 profiler API
Summary: Web Inspector: Replace hand-written profiler bindings with idl-based, [Chromi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 09:09 PDT by Mikhail Naganov
Modified: 2010-04-13 01:44 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (4.71 KB, patch)
2010-04-12 09:23 PDT, Mikhail Naganov 		yurys: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-04-12 09:09:56 PDT 
I replaced hand-written JavaScriptProfile* bindings with idl-based, and in Chromium port, I bound them to the new V8's profiler API that is aligned with JSC.
Comment 1 Mikhail Naganov 2010-04-12 09:23:00 PDT 
Created attachment 53171 [details]
proposed patch

I'll better land it myself to avoid surprising build breakages.
Comment 2 WebKit Review Bot 2010-04-13 00:34:11 PDT 
http://trac.webkit.org/changeset/57505 might have broken Chromium Linux Release
Comment 3 Mikhail Naganov 2010-04-13 01:44:06 PDT 
Manually committed http://trac.webkit.org/changeset/57505
Then followed up with build fixes for Qt and Chromium: http://trac.webkit.org/changeset/57508