Bug 37428 – [Qt] Patch to fix compilation warnings for QGraphicsWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexis Menard (darktears)]

Created attachment 53124 [details]
Patch to fix warnings.

Fix compilation warnings in QGraphicsWebView.

Trivial, should be quick to review the attached patch.

[Andreas Kling]

Created attachment 53355 [details]
Diff against trunk with ChangeLog

Thanks for the patch Alexis! I've updated it to the proper format.
Please have a look at http://trac.webkit.org/wiki/QtWebKitContrib for future contributions :-)

[Simon Hausmann]

Comment on attachment 53355 [details]
Diff against trunk with ChangeLog

> diff --git a/WebKit/qt/Api/qgraphicswebview.cpp b/WebKit/qt/Api/qgraphicswebview.cpp
> index 919a10a..b3bcbe7 100644
> --- a/WebKit/qt/Api/qgraphicswebview.cpp
> +++ b/WebKit/qt/Api/qgraphicswebview.cpp
> @@ -647,9 +647,13 @@ QVariant QGraphicsWebView::itemChange(GraphicsItemChange change, const QVariant&
>      case ItemCursorChange:
>          return value;
>      case ItemCursorHasChanged:
> -        QEvent event(QEvent::CursorChange);
> -        QApplication::sendEvent(this, &event);
> -        return value;
> +        {
> +            QEvent event(QEvent::CursorChange);
> +            QApplication::sendEvent(this, &event);
> +            return value;
> +        }

Coding style wants the opening brace on the line preceeding the code block. Only function definitions have braces on lines of their own.

Otherwise LGTM of course.

[Jocelyn Turcotte]

Created attachment 55225 [details]
Fixed style issue

[WebKit Commit Bot]

Comment on attachment 55225 [details]
Fixed style issue

Clearing flags on attachment: 55225

Committed r58877: <http://trac.webkit.org/changeset/58877>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.