Bug 37411 - [Haiku] Improve SimpleFontDataHaiku implementation
Summary: [Haiku] Improve SimpleFontDataHaiku implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-11 07:53 PDT by Stephan Aßmus
Modified: 2010-04-22 00:30 PDT (History)
1 user (show)

See Also:


Attachments
[Haiku] Improve SimpleFontDataHaiku.cpp (3.21 KB, patch)
2010-04-11 07:55 PDT, Stephan Aßmus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Aßmus 2010-04-11 07:53:43 PDT
* Removed a hack and replaced it with existing UTF8 encoding infrastructure.
* Fixed a memory leak.
Comment 1 Stephan Aßmus 2010-04-11 07:55:37 PDT
Created attachment 53089 [details]
[Haiku] Improve SimpleFontDataHaiku.cpp
Comment 2 WebKit Commit Bot 2010-04-13 22:15:00 PDT
Comment on attachment 53089 [details]
[Haiku] Improve SimpleFontDataHaiku.cpp

Rejecting patch 53089 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12673 test cases.
fast/events/platform-wheelevent-in-scrolling-div.html -> failed

Exiting early after 1 failures. 6453 tests run.
117.11s total testing time

6452 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
2 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1601449
Comment 3 Eric Seidel (no email) 2010-04-21 18:26:10 PDT
Comment on attachment 53089 [details]
[Haiku] Improve SimpleFontDataHaiku.cpp

Flaky test.
Comment 4 WebKit Commit Bot 2010-04-22 00:30:09 PDT
Comment on attachment 53089 [details]
[Haiku] Improve SimpleFontDataHaiku.cpp

Clearing flags on attachment: 53089

Committed r58068: <http://trac.webkit.org/changeset/58068>
Comment 5 WebKit Commit Bot 2010-04-22 00:30:15 PDT
All reviewed patches have been landed.  Closing bug.