Bug 37407 - Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
Summary: Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-11 00:34 PDT by Joseph Pecoraro
Modified: 2010-04-11 00:47 PDT (History)
1 user (show)

See Also:

Attachments
[PATCH] Rubber Stamp support and Cleanup (2.12 KB, patch)
2010-04-11 00:37 PDT, Joseph Pecoraro 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-04-11 00:34:15 PDT 
commit-log-editor doesn't treat a "Rubber-stamp by" like a "Reviewed by". This causes ugly output.
Comment 1 Joseph Pecoraro 2010-04-11 00:37:07 PDT 
Created attachment 53080 [details]
[PATCH] Rubber Stamp support and Cleanup 

Handles the top 3 Rubber-stamp variants:

  "Rubber-stamped by"
  "Rubber stamped by"
  "Rubberstamped by"

Also removes some old code, fixes style issues, and provides better error messages.
Comment 2 Mark Rowe (bdash) 2010-04-11 00:38:17 PDT 
Comment on attachment 53080 [details]
[PATCH] Rubber Stamp support and Cleanup 

Sure, why not.
Comment 3 Joseph Pecoraro 2010-04-11 00:47:22 PDT 
Committed r57447
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/commit-log-editor
r57447 = 3242d4a0dd22da53cd7f7fd35de11fd0272a3489 (trunk)
http://trac.webkit.org/changeset/57447